search

novuhq / novu-java

Java SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
27 stars 22 forks source link

feature request: add sdk methods for organization apis #97

Closed jainpawan21 closed 11 months ago

jainpawan21 commented 1 year ago

Take this issue as reference https://github.com/novuhq/novu/issues/4775

unicodeveloper commented 1 year ago

@Basfar @mayorJAY

Basfar commented 1 year ago

Noted, On it

mayorJAY commented 1 year ago

@jainpawan21 @Basfar https://api.novu.co/api#/Organizations/OrganizationController_getOrganizations I tried sending a request to this endpoint using Postman, but the response body I got seems to be different from what is stated on the Swagger doc. The doc seems to be confusing, this is what I got on Postman:


{
    "data": [
        {
            "_id": String,
            "name": String,
            "createdAt": "2023-06-22T21:01:05.684Z",
            "updatedAt": "2023-06-22T21:01:05.684Z",
            "__v": 0
        }
    ]
}
jainpawan21 commented 11 months ago

Hi @mayorJAY

In controller schema, all possible folds are mentioned. There are few optional fields.

createdAt, updatedAt and __v is not there. Shall we imclude these also?

unicodeveloper commented 11 months ago

@mayorJAY Has this been taken care of?

mayorJAY commented 11 months ago

Yes, @Basfar is working on it