search

novuhq / novu-kotlin

Kotlin SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
19 stars 8 forks source link

Modify Request and Response body Objects based on Recent Updates #12

Closed mayorJAY closed 12 months ago

mayorJAY commented 12 months ago

While working on the Java SDK, I discovered that the Kotlin SDK was falling short in the requirements of some endpoints in terms of Request and Response body structures. That is what this PR addresses

unicodeveloper commented 12 months ago

@mayorJAY There is no description that explains why this PR/update is needed.

  1. Please can you throw more light on why you are modifying request and response body objects?
  2. How does this affect existing users already using the package?
mayorJAY commented 12 months ago

@mayorJAY There is no description that explains why this PR/update is needed.

  1. Please can you throw more light on why you are modifying request and response body objects?
  2. How does this affect existing users already using the package?

@unicodeveloper I've added the description and the reason for the change To the 2nd question, users will be having issues with those endpoints in question already. So we'd need to do a release so they can upgrade