search

novuhq / novu-php

PHP SDK for Novu - The open-source notification infrastructure for engineers. :rocket:
https://docs.novu.co/sdks/php
MIT License
84 stars 23 forks source link

cancelEvent not working #16

Closed LenaDooms closed 1 year ago

LenaDooms commented 1 year ago

the cancelEvent function in ManagesTriggers results in an error. In its body, delete returns a boolean, as the response body of the delete request is empty. When this boolean value $response is used to create a Trigger object, an error is thrown, since Trigger expects an array, not a boolean.

unicodeveloper commented 1 year ago

Thanks for mentioning this. Taking a look at it right away @LenaDooms

LenaDooms commented 1 year ago

thanks for the quick follow up!

unicodeveloper commented 1 year ago

This has been fixed in the latest release @LenaDooms

LenaDooms commented 1 year ago

Amazing, thank you @unicodeveloper !!