novuhq / novu-python

Python SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://novu-python.readthedocs.io
MIT License
74 stars 32 forks source link

SubscriberApi. get() not returning credentials, field is missing in SubscriberDto #52

Closed prathapbelli closed 11 months ago

prathapbelli commented 1 year ago

we are using python sdk and self hosted novu, we have api for updating subscriber credentials but we don't have api to get those updated credentials info whether credentials are stored or not.

Novu getSubscriber api is returning credentials info under channel key, but in python sdk subscriberApi.get() mnot returing the same, we dont have field defined in SubscriberDto.

novu api response:

"data": [
        {
            "_id": "ffff",
            "_organizationId": "ffff",
            "_environmentId": "ffff",
            "subscriberId": "ffff",
            "email": "ffff",
            "channels": [
                {
                    "_integrationId": "fffff",
                    "providerId": "slack",
                    "credentials": {
                        "webhookUrl": "https://hooks.slack.com/services/fffffff",
                        "channel": "slack",
                        "deviceTokens": []
                    }
                }]
}]
unicodeveloper commented 1 year ago

@ryshu Please can you help with this?

@prathapbelli Please feel free to submit a PR fix for this for faster turnaround.

prathapbelli commented 1 year ago

@unicodeveloper added PR https://github.com/novuhq/novu-python/pull/53

unicodeveloper commented 1 year ago

Okay I see the PR is still in review. Please can you fix the commit issues @prathapbelli

ryshu commented 11 months ago

Merged in latest release (see https://github.com/novuhq/novu-python/tree/v1.5.0)