search

novuhq / novu-python

Python SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://novu-python.readthedocs.io
MIT License
78 stars 31 forks source link

Add Missing Methods for Notification templates #69

Open Cliftonz opened 1 year ago

Cliftonz commented 1 year ago

Some endpoints of the following section can't be hit from this SDK.

We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Notification templates

Some of these methods may already exist. 
If so no need to change/update them, just point out that they already exist and we will close the issue.

This is just to bring every SDK we have on par with all the methods available.

Check all the endpoints here and add the missing ones.

FazleRabbbiferdaus172 commented 1 year ago

Hi Cliftonz, swagger shows that endpoints under notification templates have been renamed to Workflows. Under Workflows there are 6 endpoints and all of them are implemented under NotificationTemplateApi. Trying out all 6 endpoints either responses with 401 or 403.

unicodeveloper commented 1 year ago

@FazleRabbbiferdaus172 where are you trying out the endpoints?

FazleRabbbiferdaus172 commented 1 year ago

@unicodeveloper Swagger link is provided in the issue description, I tried out the endpoints under the Workflow section.

unicodeveloper commented 1 year ago

Can you try them out in the api reference doc? https://docs.novu.co/api-reference/workflows/get-workflows @FazleRabbbiferdaus172

Add your API key so you can get the results.

CleanShot 2023-10-04 at 08 37 45

FazleRabbbiferdaus172 commented 1 year ago

@unicodeveloper Tried them out in api reference doc, Get workflows endpoint responses in 200. But do the reference docs endpoints ensure that the python sdk wroks?

unicodeveloper commented 1 year ago

@FazleRabbbiferdaus172 I am not sure if i get you correctly. But you can always use the reference docs to test any of the endpoints quickly. It's independent of the SDK.