Add Missing Methods for Workflow

novuhq / novu-python

Python SDK for Novu - The open-source notification infrastructure for engineers. 🚀

https://novu-python.readthedocs.io

MIT License

71 stars 32 forks source link

Add Missing Methods for Workflow #92

Open mr-palindrome opened 10 months ago

mr-palindrome commented 10 months ago

None of the workflow endpoints are implemented in the python-SDK.

I checked and variefied that none of the workflow APIs are implemented in python-SDK. The examples mentioned in the Novu documentations seems to be wrong.

Need verification from the maintainers on this. As the novu/constants.py (https://github.com/novuhq/novu-python/blob/main/novu/constants.py) doesn't has any /workflow/ endpoint constant.

mr-palindrome commented 10 months ago

@Cliftonz @unicodeveloper can you guys please have a look on this!

jainpawan21 commented 10 months ago

@mr-palindrome We recently renamed Notification Templates to workflows.

Yes we need to create workflows endpoints (methods) as well end mark notification templates endpoints (methods) as deprecated

mr-palindrome commented 10 months ago

@mr-palindrome We recently renamed Notification Templates to workflows.

Yes we need to create workflows endpoints (methods) as well end mark notification templates endpoints (methods) as deprecated

So can I work on this and start creating the workflow methods!

sumitsaurabh927 commented 10 months ago

@mr-palindrome any updates?

mr-palindrome commented 10 months ago

@mr-palindrome any updates?

Yeah the DTO for workflow methods has been completed.. need to add the methods and the test cases. I'll make an initial commit in the respective forked repo.