search

novuhq / novu-ruby

Ruby SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://rubygems.org/gems/novu
MIT License
23 stars 10 forks source link

Refactor/add missing api methods #40

Closed Eazybright closed 11 months ago

Eazybright commented 11 months ago

The following endpoints have the added to the SDK:

sumitsaurabh927 commented 11 months ago

Please address the comments @Eazybright

Eazybright commented 11 months ago

Please address the comments @Eazybright

I can't find any comments here @sumitsaurabh927

sumitsaurabh927 commented 11 months ago

@Eazybright please go through each commit 🙂

Eazybright commented 11 months ago

@Eazybright please go through each commit 🙂

I've search al the commits and can't find any comments still. Can you share the url of one of the comments for easy navigation?

Eazybright commented 11 months ago

@Eazybright please go through each commit 🙂

I've search al the commits and can't find any comments still. Can you share the url of one of the comments for easy navigation?

@sumitsaurabh927

sumitsaurabh927 commented 11 months ago

@Eazybright please go through each commit 🙂

I've search al the commits and can't find any comments still. Can you share the url of one of the comments for easy navigation?

@sumitsaurabh927

You can find an example here. Go through other commits similarly.

SCR-20231006-nkcb
Eazybright commented 11 months ago

Thanks. But comments are not showing on my end.

On Fri, Oct 6, 2023 at 10:38 AM Sumit Saurabh @.***> wrote:

@Eazybright https://github.com/Eazybright please go through each commit 🙂

I've search al the commits and can't find any comments still. Can you share the url of one of the comments for easy navigation?

@sumitsaurabh927 https://github.com/sumitsaurabh927

You can find an example here https://github.com/novuhq/novu-ruby/pull/40/commits/099e8768234525d839d4e200e09f9e6f1b8f4a6c. Go through other commits similarly. [image: SCR-20231006-nkcb] https://user-images.githubusercontent.com/62152915/273168328-118ad3a2-50fd-4a6b-98af-a835e300c6e3.png

— Reply to this email directly, view it on GitHub https://github.com/novuhq/novu-ruby/pull/40#issuecomment-1750291960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGEDEY4QYMQMNNHVYIZVC3X57GRDAVCNFSM6AAAAAA5RKKI5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGI4TCOJWGA . You are receiving this because you were mentioned.Message ID: @.***>

unicodeveloper commented 11 months ago

@sumitsaurabh927 I can't see any comments as well

unicodeveloper commented 11 months ago

I can see they are Pending on your end. It means you need to finish reviewing it and publish the comments so that @Eazybright and anyone looking at this PR can see the comments.

unicodeveloper commented 11 months ago

We greatly appreciate your contribution. We hope you'll stay with us and continue to be an integral part of this project.

Please consider giving this repo a star and joining our community discord server, if you haven't already, to access more resources and connect with like-minded individuals. Discord Community here 🎉 #Hacktoberfest