search

novuhq / novu-ruby

Ruby SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://rubygems.org/gems/novu
MIT License
23 stars 10 forks source link

#37 add to_json for trigger_bulk_event #45

Closed amirali-ashraf closed 7 months ago

amirali-ashraf commented 11 months ago

Hi @Eazybright ,

I made the changes, could you please review?

Eazybright commented 7 months ago

cc: @unicodeveloper

unicodeveloper commented 7 months ago

I have a question here. Why are we doing this to one method alone? What difference does it make? @Eazybright

Eazybright commented 7 months ago

There was a problem with creating bulk data at once because the sdk doesn't parse array correctly in the request body. This problem affects method that creates data in bulk. issue reference: https://github.com/novuhq/novu-ruby/issues/37