novuhq / novu-ruby

Ruby SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://rubygems.org/gems/novu
MIT License
23 stars 10 forks source link

fix: set the gemspec version using the release tag value #46

Closed Eazybright closed 11 months ago

Eazybright commented 11 months ago

This PR updates the release.yml to include a step to automatically sets the version of the SDK to be published using the value of the release tag.

unicodeveloper commented 11 months ago

@Eazybright I just tried to tag a new release.

We have an error for it trying to set up Ruby. Check here: https://github.com/novuhq/novu-ruby/actions/runs/6484505880/job/17608488730#step:4:38

CleanShot 2023-10-11 at 16 23 00

unicodeveloper commented 11 months ago

I can see that the gem.lock file here supports only universal Java 17 and that's why we have that error

https://github.com/novuhq/novu-ruby/blob/main/Gemfile.lock#L91

Eazybright commented 11 months ago

@unicodeveloper i've raised a PR for the fix: https://github.com/novuhq/novu-ruby/pull/47

unicodeveloper commented 11 months ago

@Eazybright I just tried it again. The java platform issue has been fixed correctly. But we have another issue now.

This is the action log: https://github.com/novuhq/novu-ruby/actions/runs/6490687700/job/17626846860

So for some reason, it is not using the new version number gotten from the tags to publish to Rubygems. It's still using the gemspec file version number.

unicodeveloper commented 11 months ago

Never mind. I'll fix it. I think I have figured out what to do.

unicodeveloper commented 11 months ago

A new release has been tagged 🍾 🎊 . The process to release a new version now is:

Eazybright commented 11 months ago

https://github.com/novuhq/novu-ruby/pull/46#issuecomment-1758915278

great work @unicodeveloper