novuhq / novu-ruby

Ruby SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://rubygems.org/gems/novu
MIT License
23 stars 10 forks source link

Bump version of active-support #56

Open clgiovannelli opened 10 months ago

clgiovannelli commented 10 months ago

Hi all, do you think is possible to use activesupport > 6.1.7.2 instead of activesupport = 6.1.7.2?

Thank you in advance

clgiovannelli commented 9 months ago

Any update?

unicodeveloper commented 9 months ago

Any particular reason for this request? @clgiovannelli

clgiovannelli commented 9 months ago

Thank you for getting back to me, actually I can't install the gem with the latest version of Rails.

clgiovannelli commented 8 months ago

Hi there, I'm considering integrating NOVU into our production environment. I was wondering if you have plans to continue maintaining the Ruby gem? Your guidance on this would be greatly appreciated. Thank you!

Eazybright commented 8 months ago

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

jainpawan21 commented 8 months ago

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

@Eazybright would you like to work on this?

unicodeveloper commented 8 months ago

I have tagged a new release. v1.1.0. Please update your gem @clgiovannelli

clgiovannelli commented 7 months ago

Hi @unicodeveloper,

After updating the gem, it appears that it can't find exponential-backoff and uuid. In fact, these dependencies were not defined in the gemspec. I resolved the issue by manually adding the gems to the bundler. However, it would be greatly appreciated if these dependencies could be included in the gemspec.

Thank you in advance.

Eazybright commented 7 months ago

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it https://github.com/novuhq/novu-ruby/pull/65

clgiovannelli commented 7 months ago

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it #65

It's working, thank you!