search

novuhq / novu-ruby

Ruby SDK for Novu - The open-source notification infrastructure for engineers. 🚀
https://rubygems.org/gems/novu
MIT License
23 stars 10 forks source link

Fix/add dependency to gemspec #65

Closed Eazybright closed 7 months ago

clgiovannelli commented 7 months ago

Sorry to bother you again but I get this error:

Could not find compatible versions

Because rails >= 7.1.0, < 7.1.1 depends on activesupport = 7.1.0
 and rails >= 7.1.1, < 7.1.2 depends on activesupport = 7.1.1,
 rails >= 7.1.0, < 7.1.2 requires activesupport = 7.1.0 OR = 7.1.1.
And because rails >= 7.1.2, < 7.1.3 depends on activesupport = 7.1.2,
 rails >= 7.1.0, < 7.1.3 requires activesupport = 7.1.0 OR = 7.1.1 OR = 7.1.2.
And because rails >= 7.1.3 depends on activesupport = 7.1.3
 and novu >= 1.2.0 depends on activesupport >= 6.1.7.2, < 7.A,
 rails >= 7.1.0 is incompatible with novu >= 1.2.0.
So, because Gemfile depends on novu >= 1.2.0
 and Gemfile depends on rails ~> 7.1.0,
 version solving has failed.
unicodeveloper commented 7 months ago

@Eazybright what could really be the issue here? The activesupport is set to:

spec.add_dependency "activesupport", "~> 6.1", ">= 6.1.7.2"
Eazybright commented 7 months ago

@Eazybright what could really be the issue here? The activesupport is set to:

spec.add_dependency "activesupport", "~> 6.1", ">= 6.1.7.2"

activesupport "~> 6.1", ">= 6.1.7.2" can be explained as follows:

  1. "~> 6.1" accept versions identical to >= 6.1 and < 6.2.
  2. ">= 6.1.7.2" can accept version upwards but "rule 1" has made it useless because it pegs it to < 6.2.

So there is a conflict with the comparison.

The fix should be spec.add_dependency "activesupport", "~> 6.1", ">= 6.2"

unicodeveloper commented 7 months ago

@Eazybright Please can you send a PR to fix this?

Eazybright commented 7 months ago

done https://github.com/novuhq/novu-ruby/pull/68

unicodeveloper commented 7 months ago

We just tagged a 1.3.0 release. Please can you try again with the new version? @clgiovannelli