search

novuhq / novu-rust

MIT License
17 stars 13 forks source link

chore: update msrv version #22

Closed king-11 closed 11 months ago

king-11 commented 11 months ago

Fixes #21 Fixes #8

Signed-off-by: Lakshya Singh lakshay.singh1108@gmail.com

king-11 commented 11 months ago

@Cliftonz requesting your review

Cliftonz commented 11 months ago

@king-11 Why was this only updated to 1.63? currently 1.72 is the lastest version.

king-11 commented 11 months ago

The stable channel in CI already points to 1.72.1 here I have added in the minimum supported version of our SDK which is 1.63 as of now.

king-11 commented 11 months ago

@Cliftonz am I missing on something 😅 else or does it look good for merging?

Cliftonz commented 11 months ago

Just got lost in the sea of prs, thanks for the ping

king-11 commented 11 months ago

Shall we merge it now?