Closed EshaanAgg closed 11 months ago
Hey @kymppi Palease can you help review this PR?
@unicodeveloper @kymppi Can you please add the hacktoberfest
tag to this repository or the hacktoberfest-accepted
label to this PR?
@unicodeveloper @kymppi Can you please add the
hacktoberfest
tag to this repository or thehacktoberfest-accepted
label to this PR?
That was added yesterday.
@unicodeveloper
I can't see the same. It must either be the hacktoberfest
tag on the repository or the hacktoberfest-accepted
tag on a PR. I can only see the hacktoberfest
tag on my PR, causing the same to be excluded from the count of Hacktoberfest.
Also when will this PR be merged? I would love to add additional functionality to this repository once this base PR is merged.
@unicodeveloper Am I missing something? Is there any additional step in getting the PR merged?
We greatly appreciate your contribution. We hope you'll stay with us and continue to be an integral part of this project.
Please consider giving this repo a star and joining our community discord server, if you haven't already, to access more resources and connect with like-minded individuals. Discord Community here 🎉 #Hacktoberfest
This PR fixes part of #15.
I have added the
changes.rs
file, which implements one method to get all the changes for now. I first wanted to use this PR as a proof of concept and get confirmation, after which I would add more endpoints.The primary concerns I had were:
Option
to represent the optional query parameters and created a custom utility function calledgenerate_query_url
to get the query string from multiple optional parameters. Does this implementation look good? Should we consider shifting this function to a more "global" crate?