novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.36k stars 3.92k forks source link

[NV-1248] 🚀 Feature: Use the Provider's template. #1138

Closed xioxin closed 6 months ago

xioxin commented 2 years ago

🔖 Feature description

Provides a new type of integration that serves to combine the template id and Variable and forward it to the SMS provider.

🎤 Why is this feature needed ?

In China SMS templates must be reviewed by the provider. The provider's interface is to pass the SMS template id and variables, not the full text content.

✌️ How do you aim to achieve this?

Add a forward type integration. Add an action in Workflow Editor, select Integration in the action and fill in the template id from the vendor.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

🏢 Have you read the Code of Conduct?

My native language is not English, so there may be errors in the description.

NV-1248

scopsy commented 2 years ago

Thank you for reporting this @xioxin! What providers support this behavior of passing a template id? Do we have those integrations in Novu or it is for new providers targeting china?

xioxin commented 2 years ago

new providers targeting china.

SMS provider related api documentation (Chinese, may need translation software help) https://help.aliyun.com/document_detail/419273.htm https://www.mysubmail.com/documents/OOVyh

scopsy commented 2 years ago

Thank you for this information @xioxin this is very helpful!

scopsy commented 6 months ago

Can be handled with provider overrides with Echo https://docs.novu.co/echo/quickstart