novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.46k stars 3.51k forks source link

🐛 Bug Report: Integration store FCM is not at par with the docs #1303

Closed saby22 closed 1 year ago

saby22 commented 1 year ago

📜 Description

Steps mentioned in the docs to integrate FCM with Novu.

To enable the FCM integration, you need to get your service account key from the Firebase dashboard. You can acquire the account key JSON by selecting your project, clicking the gear icon in top of the sidebar, going to service account tab and download the JSON. After that, manually get the values from the JSON to the right fields. You can use a tool like JSON Formatter to get the values more easily.

However, the form to add FCM as an integration only contains one field by the name of service account. What are we supposed to paste over there? The whole JSON file or something else?

👟 Reproduction steps

  1. Navigate to the Integration Store in admin panel
  2. Try to connect FCM , which is mentioned under Push

👍 Expected behavior

Should contain multiple form fields.

👎 Actual Behavior with Screenshots

Screenshot 2022-09-27 170442 Contains only one field by the name of service account.

💻 Operating system

Windows

🤖 Node Version

16.17.1

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

No response

BiswaViraj commented 1 year ago

Hello @saby22, thank you for raising this issue. You'll need to paste the entire service account JSON in that field. I'll look into the docs and update them later with the proper steps. Let me know if you need any more help.

saby22 commented 1 year ago

Got it. It works. Thanks for the clarification @BiswaViraj

scopsy commented 1 year ago

@saby22 @BiswaViraj maybe worth adding this in the field description? @saby22 do you want to create a PR for that?

saby22 commented 1 year ago

@scopsy cool, I can take that up. Reopening just to track this one.

oba2311 commented 1 year ago

@saby22 good luck!