novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.58k stars 3.53k forks source link

πŸš€ Feature: Azure Active Directory Authentication #2153

Open wh1337 opened 1 year ago

wh1337 commented 1 year ago

πŸ”– Feature description

Currently, there are two ways to login. You have the GitHub OAuth 2 provider, and then you have your standard username password configuration.

I would like to propose an additional login method utilizing Azure Active Directory.

🎀 Why is this feature needed ?

Allowing users to authenticate with Azure Active Directory could aid in the adoption of Novu with Microsoft heavy companies.

✌️ How do you aim to achieve this?

There will need to be the addition of the following env vars (note: AAD is the standard abbreviation for Azure Active Directory)

AAD_CLIENT_ID
AAD_CLIENT_SECRET

Route: /v1/auth/aad Would check to see if the env vars are set. Like it does here for GitHub

Route: /v1/auth/aad/callback Exchange the code for a token, reach out to the Microsoft Graph and get the user details and store it in the database layer.

πŸ”„οΈ Additional Information

https://learn.microsoft.com/en-us/azure/active-directory/fundamentals/auth-oauth2

πŸ‘€ Have you spent some time to check if this feature request has been raised before?

🏒 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Cliftonz commented 1 year ago

This has been brought up, however, there needs to be further discussion internally before we move forward. I would defer to @scopsy on this.

@cryptic-ai what is your use case for wanting this? Compliance, Security, Standard Integration, Easy of use, etc.

wh1337 commented 1 year ago

This has been brought up, however, there needs to be further discussion internally before we move forward.

I would defer to @scopsy on this.

@cryptic-ai what is your use case for wanting this? Compliance, Security, Standard Integration, Easy of use, etc.

My use case will be the following:

Cliftonz commented 1 year ago

Thank you!

wh1337 commented 1 year ago

Just bumping this to see if there's been any update :)

scopsy commented 1 year ago

Hi @wh1337 unfortunately not at the moment, will update here once we have some news regarding that πŸ™