[NV-1745] 🐛 Bug Report: Use more fields of user in identify service

[ali-master]

📜 Description

It seems we can add more fields about users in Novu DB while identifying as I can see in TS ISubscriberPayload interface.

export interface ISubscriberPayload {
    firstName?: string;
    lastName?: string;
    email?: string;
    phone?: string;
    avatar?: string;
    locale?: string;
    [key: string]: string | string[] | boolean | number | undefined;
}

But it doesn't work as well as expected and just reserved fields would be inserted. When I retrieve the User in Novu, the custom fields don't retrieve. for example, we want to use some device information in identifying services such as these props:

• birthday
• isBanned
• registeredAt
• appVersion
• manufacturer
• system
• model
• isAndroid

You may be asking me why? I'll tell you, assume that I want to send a promotion push to every android device by manufacturer or send a birthday message push to every user that their birthday is on x day. so How can I do this? I used the Novu to manage all these things, not just the system that manages multi providers. Every Marketing team needs this critical feature to communicate or engage more and more with their users.

👟 Reproduction steps

Try to use custom fields in identify SDK method.

👍 Expected behavior

All custom fields should be added to Novu DB and should be visible in Admin Panel and retrievable by getUser SDK's method.

👎 Actual Behavior with Screenshots

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• [X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• [X] I have read the Contributing Guidelines

Are you willing to submit PR?

Yes I am willing to submit a PR!

_NV-1745

[scopsy]

@ali-master seems like the TS definition is wrong :( Could you try updating the the subscriber and passing all custom metata inside data object? https://docs.novu.co/api/create-subscriber/

We will need to update the TS definition so it will have a data object:

 data: {    [key: string]: string | string[] | boolean | number | undefined; }

Will you want to help with this?

[ali-master]

@ali-master seems like the TS definition is wrong :( Could you try updating the the subscriber and passing all custom metata inside data object? https://docs.novu.co/api/create-subscriber/

We will need to update the TS definition so it will have a data object:

 data: {    [key: string]: string | string[] | boolean | number | undefined; }

Will you want to help with this?

Can we send a push to everyone who matches their data prop to some conditions? For example I want to send an update push to everyone who matches these conditions as below:

{
    isAndroid: true,
    appVersion: "1.12.3" 
}

[scopsy]

@ali-master unfortunately, not at the moment. This could potentially be possible with the broadcast endpoint, but we lack filters there at the moment. Could you open a new issue for this:?

[ali-master]

@ali-master unfortunately, not at the moment. This could potentially be possible with the broadcast endpoint, but we lack filters there at the moment. Could you open a new issue for this:?

Of course, I'll create a new one.

[oba2311]

@scopsy if a new issue will be opened - can we close this one?

[scopsy]

Let's first open one so we can link between the two 🙏

[oba2311]

@ali-master wanted to make sure you still interested in working on this and opening the ticket. thanks