novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.15k stars 3.78k forks source link

[NV-2199] 🐛 Bug Report: Un processable Entity and Wrong Typing #3316

Open olawalejuwonm opened 1 year ago

olawalejuwonm commented 1 year ago

📜 Description

Trying to trigger a notification with the data shown in the image below image It turns out that icon is not supported in FCM and the imageUrl that's specified to be supported is not in the typings and it gives error has shown below image

👟 Reproduction steps

Using this image

👍 Expected behavior

It should have correct typings

👎 Actual Behavior with Screenshots

image

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

NV-2199

scopsy commented 1 year ago

@olawalejuwonm thank you for submitting! assigned you to this issue, let me know if help is needed 🙏