search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.5k stars 3.52k forks source link

[NV-2295] 🐛 Bug Report: template object missing in GET feed response #3381

Open phlrss opened 1 year ago

phlrss commented 1 year ago

📜 Description

the API docs show an optional template object in response to the GET feed endpoint, but there is no way to specify it in the request and it is missing from the resopnse

👟 Reproduction steps

call the GET feed endpoint here: https://docs.novu.co/api/get-a-notification-feed-for-a-particular-subscriber/

👍 Expected behavior

expected to have the template object or at least be able to specify that we want it in the request

👎 Actual Behavior with Screenshots

it is missing from the response completely :(

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

NV-2295

peoray commented 1 year ago

can I pick up this up @jainpawan21

jainpawan21 commented 1 year ago

Sure assigned to you @peoray

peoray commented 1 year ago

@jainpawan21 how can I produce this to see the end result from the endpoint. My data property returns an empty array all the time. Seems I have to do other things first to produce data it can use. Can you help?

sumitsaurabh927 commented 1 year ago

@ainouzgali can you help with this?

ainouzgali commented 1 year ago

@peoray all you need to reproduce is to create a template with an in-app step and then trigger it. So when you query that endpoint, template in response should be populated. Right now, it will always return an empty array.

I believe the solution will be to populate template here

peoray commented 1 year ago

@ainouzgali Thank you. Are there specific fields to be returned or I just return everything?

peoray commented 1 year ago

@phlrss what fields do you want to be returned so that we don't return the whole object cause of performance

phlrss commented 1 year ago

@phlrss what fields do you want to be returned so that we don't return the whole object cause of performance

hey! sorry for the delay, we would at the very least need the template.triggerId and the group 🙏 both are important

parth-pandeyy commented 11 months ago

Is anyone working on it? If not, could you please assign it to me?

phlrss commented 9 months ago

hi 👋 i see a few people have volunteered to work on this but it doesn't look like it's completed. Any update?

Prashant-dot1 commented 9 months ago

Hi @jainpawan21 @phlrss , I have worked on this issue . PR for this is created - let me know how this can be tested throughly

Prashant-dot1 commented 9 months ago

Can this PR be assigned to me ? Should I make my PR a draft as it is not assigned to me rn