novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.01k stars 3.47k forks source link

[NV-2697] senderName field is missing in resend api and nodejs sdk #3957

Closed jainpawan21 closed 10 months ago

jainpawan21 commented 1 year ago

What?

Novu allows using sender name field in email editor and via overrides. If sender name is Pawan Jain and sender from email is pawan@novu.co, in email clients shows like this Pawan Jain <pawan@novu.co>

Why? (Context)

In the case of resend provider, it does not have a separate sender name field.

Ref API:- https://resend.com/docs/api-reference/emails/send-email

currently, there are two ways to handle this:-

  1. use from field like this in integration modal

image

  1. or use overrides like this     "overrides": {         "email":{             "from": "Pawan Jain Novu <pawan@novu.co>"         }     }

Users get confused about why the sender's name is not showing up correctly.

Definition of Done

  1. Novu should automatically handle this at provider implementation
  2. Update docs accordingly

From SyncLinear.com | NV-2697

gitstart commented 1 year ago

@scopsy @jainpawan21 we would like to pick this up

Sangam-ghimire commented 11 months ago

Hey @jainpawan21 @scopsy I would love to help here...seems pretty interesting

scopsy commented 11 months ago

@Sangam-ghimire assigned you 🙏

Sangam-ghimire commented 11 months ago

@scopsy @jainpawan21 I am having trouble setting up the project locally, I have asked it in the discord channel as well. image I am stuck here, and the error is not getting resolved for now.

scopsy commented 11 months ago

@Sangam-ghimire could you try running npm run setup:project from project root?

Sangam-ghimire commented 11 months ago

@Sangam-ghimire could you try running npm run setup:project from project root?

I have done that and whats next? is it optional to setup enviroment from npm start after npm run project:setup?

Sangam-ghimire commented 11 months ago

@Sangam-ghimire could you try running npm run setup:project from project root?

I have done that and whats next? is it optional to setup enviroment from npm start after npm run project:setup?

@scopsy basically I have completed successfully, npm run project:setup and while setting up the env from npm start I have faced the error shown above

DhairyaMajmudar commented 10 months ago

@Sangam-ghimire is you are still working in this issue. If no pls. assign me this issue

piyushgarg-dev commented 10 months ago

Please check PR #4237

scopsy commented 10 months ago

Assigned @piyushgarg-dev for this issue. 🙏