novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.46k stars 3.51k forks source link

πŸ› Bug Report: Error integrating @novu/notification-center-angular #3988

Closed lukasgreussing closed 10 months ago

lukasgreussing commented 1 year ago

πŸ“œ Description

Hi, I've tried to integrate @novu/notification-center-angular into a fresh angular app, exactly how it is described in the quickstart: https://docs.novu.co/overview/quickstart/get-started-with-angular#install-novu-angular-notification-center-package

I'm getting an "Cannot read properties of null (reading 'bindingStartIndex')" error and Angular is not able to render the notification center component.

image

πŸ‘Ÿ Reproduction steps

  1. Go through Angular Quickstart step by step with the current Angular version 16.2.0
  2. Run the app

πŸ‘ Expected behavior

Notification center should be rendered in the Angular app without an error

πŸ‘Ž Actual Behavior with Screenshots

image

Novu version

Self hosted Novu version 0.17.1

npm version

8.19.2

node version

18.12.1

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

🏒 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

ArslanYM commented 1 year ago

Can I work on this?

scopsy commented 1 year ago

Sure @ArslanYM πŸ™

LetItRock commented 1 year ago

hey @lukasgreussing! πŸ‘‹ from what I remember we do only support angular 15

lukasgreussing commented 1 year ago

hello @LetItRock, thanks for your reply! ok, but in the Angular quickstart requirements section it just says Angular version > 0.15.0 (I assume it's supposed to be 15.0.0). Anyhow, are there plans to support Angular 16 as well? https://docs.novu.co/overview/quickstart/get-started-with-angular/#requirements

LetItRock commented 1 year ago

hello @LetItRock, thanks for your reply! ok, but in the Angular quickstart requirements section it just says Angular version > 0.15.0 (I assume it's supposed to be 15.0.0).

sorry about that, we will update it in the docs πŸ™ @jainpawan21 fyi

Anyhow, are there plans to support Angular 16 as well? https://docs.novu.co/overview/quickstart/get-started-with-angular/#requirements

no as for now ;)

RaminGe commented 11 months ago

Hey there, we are really looking forward to get novu running with Angular 16. We now have removed the angular novu package and are using the iFrame as workaround, but that is not a permanent solution.

Bye the way, the same issue as described als occurs with the webcomponent integration.

jainpawan21 commented 11 months ago

Hey there, we are really looking forward to get novu running with Angular 16. We now have removed the angular novu package and are using the iFrame as workaround, but that is not a permanent solution.

Bye the way, the same issue as described als occurs with the webcomponent integration.

@RaminGe We have included this in our upcoming cycle. fix will be deployed around mid to end October.

Can you please share video recording / screenshot if you are able to reproduce this in web component?

lukasgreussing commented 11 months ago

@jainpawan21 great news πŸ‘ thanks for including this issue in the upcoming cycle. By the way, our workaround is utilizing the webcomponent in Angular 16 and we have no issue with that.

RaminGe commented 11 months ago

Hey there, we are really looking forward to get novu running with Angular 16. We now have removed the angular novu package and are using the iFrame as workaround, but that is not a permanent solution. Bye the way, the same issue as described als occurs with the webcomponent integration.

@RaminGe We have included this in our upcoming cycle. fix will be deployed around mid to end October.

Can you please share video recording / screenshot if you are able to reproduce this in web component?

Nice to hear, thanks for the update! Regarding the web component, my bad. I just checked it again and it was just a leftover of the angular package which was throwing the error because I forgot to remove the import. Using the web component for now as a workaround.

rifont commented 10 months ago

The fix to support Angular 15+ in @novu/notification-center-angular will be included in release v0.21.0 of Novu.