search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.47k stars 3.51k forks source link

[NV-2930] [NV-2792] Add request header to node sdk #4233

Open jainpawan21 opened 11 months ago

jainpawan21 commented 11 months ago

What?

Add request header to node sdk. Example:

headers: {
   Authorization: `Bearer ${ApiKey}`,
   "User-Agent": `novu/node@${version}`,
},

Why? (Context)

Having request headers in the SDKs will help us in monitoring which SDK is mostly used by the community and customers. It will help us make the decision to officially maintain that SDK in the future. We will be able to filter out requests on our API by that header.

Definition of Done

FroostyCodes commented 11 months ago

I would like to work on this issue @jainpawan21

DarkPheonix12 commented 11 months ago

Hey, I am ready to work on it!!nPLease assign this to me @jainpawan21 and @LetItRock

harshhere905 commented 11 months ago

i would like to work on it...

LetItRock commented 11 months ago

I would like to work on this issue @jainpawan21

@FroostyCodes hey, the ticket is yours ;)

LetItRock commented 11 months ago

hey @DarkPheonix12 @harshhere905! 👋 we do really appreciate your willingness to help, we have many more tickets out here ;) or you can run the app and suggest to us what can be improved ;) or just improve some TS types, and add missing tests :)