novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.7k stars 3.46k forks source link

[NV-2955] 🚀 Feature: Add Signal SMS Provider #4372

Open Cliftonz opened 9 months ago

Cliftonz commented 9 months ago

🔖 Feature description

Use the documentation for the Unoffical Signal Rest api from Github to create an SMS provider for Signal while following Novu's guide to a new provider.

This is not a beginner friendly issue as it require some setup to run and test.

Once accepted, the PR's MUST have a gif or pictures of the full process working.

DO NOT INCLUDE PERSONAL INFO!

🎤 Why is this feature needed ?

add more providers for the community

✌️ How do you aim to achieve this?

community contributions

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

NV-2955

Kanav-Arora commented 9 months ago

Please assign me this issue.

AnuMessi10 commented 9 months ago

Hi, let me know if you can assign this issue to me, thanks.

davidsoderberg commented 9 months ago

@AnuMessi10 will assign you because @Kanav-Arora already is assigned to an issu :)

nick2432 commented 8 months ago

can i work on this issue?

Cliftonz commented 8 months ago

@nick2432 yes

utkarsh2310 commented 7 months ago

can I work on this issue @Cliftonz

utkarsh2310 commented 7 months ago

@jainpawan21 @Cliftonz To add this provider, we need a container setup. Do I need to do that in the package as well or just have to write code for provider assuming all the container setup will be there?

Cliftonz commented 7 months ago

@utkarsh2310 You would create a docker compose file and add it to the package under a docker folder. Within the compose file you will have the container definition to set up the signal container. This way we can test in the future if need be.