novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.46k stars 3.51k forks source link

[NV-2971] [NV-2842] Add Trigger Identifier to the Subscriber Preferences response #4417

Closed jainpawan21 closed 10 months ago

jainpawan21 commented 11 months ago

What?

Add the triggers field to be part of the response to the query. The mapping functionality is included in this file: https://github.com/novuhq/novu/blob/58c46d72367f0f71bb0dd6b2014c2d5c6a8adcc3/packages/application-generic/src/usecases/get-subscriber-template-preference/get-subscriber-template-preference.usecase.ts#L252

Why?

Some users would love to filter the preferences based on the identifier of the trigger.

Definition of Done

From SyncLinear.com | NV-2842

NV-2971

suryanshsoni120 commented 11 months ago

I would like to work on this. Can you assign it to me?

Ashish2271 commented 11 months ago

I would like to work on this issue. Can you please assign this issue to me?

manish7017 commented 11 months ago

Could you please assign this issue to me? I would like to work on it

davidsoderberg commented 11 months ago

@suryanshsoni120 I will assign you now

Itsamanjain commented 11 months ago

@davidsoderberg , when I am running the web project on my localhost at port 4200, a login page appears, prompting for login either through GitHub or by using an email. I have tried both options but cannot successfully log in. Is there a default username and password for logging in during the localhost development phase?

davidsoderberg commented 11 months ago

No you need to sign up to be able to login, please use discord for further questions :)

Abhrajitdas02 commented 11 months ago

@davidsoderberg I would like to work on this. Can you assign it to me?

vichustephen commented 11 months ago

I would like to take this up. Please assign it to me

nick2432 commented 11 months ago

can i work on this issue?

Chandan-Singh10 commented 11 months ago

I am willing to work on this issue please assign me this issue

scopsy commented 11 months ago

Hi @suryanshsoni120 any updates on your end? Let me know if I should assign someone else on this

ayushshukla7777 commented 11 months ago

hey @jainpawan21 @scopsy , I was attemping to solve this issue and found that trigger is of type NotificationTriggerEntity which is in @novu/dal. While the Interface where I need to add trigger is in @novu/shared. Importing @novu/dal in @novu/shared causes dependency circle. image

suryanshsoni120 commented 11 months ago

I was actually facing difficulties in setup. It's resolved and am working on the issue.

djabarovgeorge commented 11 months ago

Due to the urgency of this issue and the lack of a current solution, I've taken the initiative to raise a PR to resolve it.

Thank you for your understanding.