Closed jainpawan21 closed 10 months ago
I would like to work on this. Can you assign it to me?
I would like to work on this issue. Can you please assign this issue to me?
Could you please assign this issue to me? I would like to work on it
@suryanshsoni120 I will assign you now
@davidsoderberg , when I am running the web project on my localhost at port 4200, a login page appears, prompting for login either through GitHub or by using an email. I have tried both options but cannot successfully log in. Is there a default username and password for logging in during the localhost development phase?
No you need to sign up to be able to login, please use discord for further questions :)
@davidsoderberg I would like to work on this. Can you assign it to me?
I would like to take this up. Please assign it to me
can i work on this issue?
I am willing to work on this issue please assign me this issue
Hi @suryanshsoni120 any updates on your end? Let me know if I should assign someone else on this
hey @jainpawan21 @scopsy , I was attemping to solve this issue and found that trigger is of type NotificationTriggerEntity which is in @novu/dal. While the Interface where I need to add trigger is in @novu/shared. Importing @novu/dal in @novu/shared causes dependency circle.
I was actually facing difficulties in setup. It's resolved and am working on the issue.
Due to the urgency of this issue and the lack of a current solution, I've taken the initiative to raise a PR to resolve it.
Thank you for your understanding.
What?
Add the
triggers
field to be part of the response to the query. The mapping functionality is included in this file: https://github.com/novuhq/novu/blob/58c46d72367f0f71bb0dd6b2014c2d5c6a8adcc3/packages/application-generic/src/usecases/get-subscriber-template-preference/get-subscriber-template-preference.usecase.ts#L252Why?
Some users would love to filter the preferences based on the identifier of the trigger.
Definition of Done
GET /:subscriberId/preferences/:templateId
response contains the triggers array in thetemplate
field.apps/api/src/app/subscribers/e2e/get-preferences.e2e.ts
to cover the functionalityFrom SyncLinear.com | NV-2842
NV-2971