novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.75k stars 3.55k forks source link

🐛 Bug Report: Missing Sender Name in Mandrill (Email) Provider #4558

Closed emersonliuuu closed 12 months ago

emersonliuuu commented 1 year ago

📜 Description

Sender Name doesn't work in Mandrill Provider, as the current implementation is missing the from_name parameter required by Mandrill to set up the sender's name in the email.

👟 Reproduction steps

  1. Setup Mandrill provider in Novu Cloud
  2. Create a workflow and implement a email template with Mandrill provider
  3. Send a test email and check it in your inbox.
  4. You might find there's no sender name.

👍 Expected behavior

SenderName <email@domain.com> is the expected value in the from field in received email

👎 Actual Behavior with Screenshots

Actually will only receive email@domain.com, although you have set up the Sender Name in Novu.

Novu version

0.20.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

krishanu7 commented 1 year ago

please assign me

saikiran76 commented 1 year ago

Please assign me this issue.