search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.01k stars 3.47k forks source link

[NV-3072] Workflow update button should show loading state when clicked #4703

Closed jainpawan21 closed 9 months ago

jainpawan21 commented 9 months ago

What?

Whenever we add new step or change anything in any of the workflow step, update button becomes active

Why? (Context)

After updating the step or workflow settings, when user clicks on the update button. it gets freezes for few seconds. User may click multiple times.

https://github.com/novuhq/novu/assets/39362422/cdc93613-e1c6-4085-b0ce-5f92de5ded6b

Definition of Done

Update button should show loading state

From SyncLinear.com | NV-3072

AkshitSinghal224 commented 9 months ago

hii team, i would like to work on this issue but i am not able to open this recorded video can you help me with that.

sudhanshugautam2911 commented 9 months ago

yes...Unable to play video.

jainpawan21 commented 9 months ago

Updated description with correct video link

iknlaxmi commented 9 months ago

hi,I would like to contribute to this issue.

jainpawan21 commented 9 months ago

Assigned to you @iknlaxmi

jainpawan21 commented 9 months ago

@iknlaxmi how is it going?

iknlaxmi commented 9 months ago

@jainpawan21 Almost done today or tomorrow I will submit PR.

iknlaxmi commented 9 months ago

@jainpawan21 I have submitted PR. Please review.