search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.5k stars 3.52k forks source link

🐛 Bug Report: Button Content and URLs Getting Escaped Regardless of Triple Curly Braces #4851

Closed JoeyEamigh closed 7 months ago

JoeyEamigh commented 10 months ago

📜 Description

Even when using triple curly braces ({{{variable}}}) in the editor, button content and urls are escaped.

👟 Reproduction steps

  1. Create an email template with a button and enter {{{url}}} into the url field
  2. Trigger the template with an entity you do not want escaped (like https://example.com?email=button+testing@example.com)
  3. Observe as the url is escaped, breaking the link

👍 Expected behavior

The url should not be escaped, leaving the link intact.

👎 Actual Behavior with Screenshots

The url is escaped.

Novu version

next branch

npm version

8.19.4

node version

v16.20.2

📃 Provide any additional context for the Bug.

I have a PR ready with some tests, just creating the issue.

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

JoeyEamigh commented 7 months ago

closed by #4852 - forgot to close the issue :)