novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.63k stars 3.54k forks source link

📡 Replace Provider Identifier with Integration Identifier #5061

Open LetItRock opened 8 months ago

LetItRock commented 8 months ago

What?

On the integrations page, we show the provider identifier with each integration

Monosnap Integrations | Novu Manage Platform 2023-11-03 11-12-45.png Monosnap Integrations | Novu Manage Platform 2023-11-03 11-20-37.png

image.png



Why? (Context)

It should be Integration Identifier because in code there is no any variable with name as providerIdentifier

Instead we have integrationIdentifier variable at many places.
One such use case is to override email/sms provider. Here sendgrid-DqJizp2Zt is Integration Indentifier (or as per image Provider Identifier)

{
 "overrides": {
   "email": {
     "integrationIdentifier": "sendgrid-DqJizp2Zt"
   }
  }
}

Definition of Done

linear[bot] commented 8 months ago

NV-3151 📡 Replace Provider Identifier with Integration Identifier

AlexVCS commented 8 months ago

hi there, I'd like to work on this issue. can you assign it to me please?

KaoutharAsma commented 8 months ago

can I work on this ?

animeshMondal-crypto commented 8 months ago

It is not closed yet, so can i try out this issue??

LetItRock commented 8 months ago

hey @AlexVCS! 👋 assigned this ticket to you ;)

developerdhruv commented 8 months ago

Want to work on it

ayo6706 commented 5 months ago

Is this still open to being worked on?