novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.91k stars 3.69k forks source link

🐛 Bug Report: updating notification center encryption not available at Nodejs SDK #5130

Open underfisk opened 9 months ago

underfisk commented 9 months ago

📜 Description

Breaking change at environments API from 0.15.0 to 0.22.0. Updating encryption through the API no longer exists or is referenced in the changelog

// Desired status is whatever we want and in my use case, comes from ENV
const desiredStatus = true
const response = await this.novu.environments.updateWidget({ notificationCenterEncryption: desiredStatus })

As you can see the API above is valid at 0.15.0 and the use case is to sync any instance running with the provided config to my custom Nestjs wrapper around Novu (this wrapper syncs configurations that come from env/dynamic with the running tenant and encryption is one of the properties)

👟 Reproduction steps

  1. Install the latest version or starting from ``
  2. Observe that environments no longer exposes a way to update a widget or encryption status at all expose

👍 Expected behavior

A method that is exposed through the SDK in order to facilitate encryption toggling

👎 Actual Behavior with Screenshots

No longer exists, might have been changed and there might be another way of doing but it wasn't listed/referencedIt no

Novu version

0.16.0 or anything after 0.15.0

npm version

8.18.2

node version

18.12.0

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

linear[bot] commented 9 months ago

NV-3463 🐛 Bug Report: updating notification center encryption not available at Nodejs SDK