novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.68k stars 3.46k forks source link

🐛 Bug Report: Tenant Feature not working for selecting Providers #5345

Open gowtham18k opened 3 months ago

gowtham18k commented 3 months ago

📜 Description

Currently, I'm facing a problem. I have 2 diff FCM providers. There is an option to add conditions using the tenant. I'm still testing that but it is not working. Even though I added the tenant key in the trigger Api notifications triggered with two providers.

👟 Reproduction steps

  1. Create Two Firebase Providers for 2 different apps.
  2. Create Individual Tenants for Both
  3. Add the Provider Condition using the tenant identifier
  4. Create a workflow with Push notification setp
  5. Create a subscriber and add two diff FCM token for a single subscriber
  6. Trigger the workflow for the created subscriberdifferent

👍 Expected behavior

if the provider conditions are added and the event trigger tenant is also added then Notification needs to be received in a particular app.

👎 Actual Behavior with Screenshots

Notification is receiving two apps eventhough tenant conditions are added.

Novu version

Novu SaaS

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

linear[bot] commented 3 months ago

NV-3626 🐛 Bug Report: Tenant Feature not working for selecting the FCM Provider