🚀 Feature: Support SendGrid ASM parameters - Githubissues

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.

https://novu.co

Other

33.77k stars 3.46k forks source link

🚀 Feature: Support SendGrid ASM parameters #5402

Open dmgarland opened 3 months ago

dmgarland commented 3 months ago

🔖 Feature description

ASM groups are a SendGrid feature designed to allow e-mail suppressions short of stopping all mail.

The SendGrid API supports asm as an option, where the group id is matched against the recipient to see whether they should be sent mail or not.

Currently the Novu SendGrid provider doesn't support asm parameters passed via customData. This patches that to allow an asm group id to be passed directly through to SendGrid

🎤 Why is this feature needed ?

We have a use case where an ASM group is shared with other parts of our platform that require to send mail, so we need to suppress mail being sent to members of that group.

✌️ How do you aim to achieve this?

I will change the SendGrid provider to allow the passing of this option

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Contributing Guidelines

Are you willing to submit PR?

Yes I am willing to submit a PR!

linear[bot] commented 3 months ago

NV-3648 🚀 Feature: Support SendGrid ASM parameters

Abobos commented 1 month ago

Can I work on this issue?