novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.01k stars 3.47k forks source link

πŸš€ Tech Feature: Specify the tenant id as HTTP header #5741

Open alexanderhofstaetter opened 2 months ago

alexanderhofstaetter commented 2 months ago

πŸ”– Feature description

we seperate our clients by different tenants, and use novu as a central notification plattform. We operate a reverse proxy before novu and we need to map and validate the requests to the corresponding tenants.

🎀 Why is this feature needed ?

We use a custom JWT based auth proxy and we need to verify that the auth client_id matches (or allows) the specific tenant_id.

We currently have to look into the request body which can get pretty annoying, especially

✌️ How do you aim to achieve this?

add a tenant_id header to api calls. when this header is present, no tenant data is allowed in the body and everything gets mapped to the specific tenant.

if the tenant is not present, the tenants get auto created only with the id (additional data can be added later - e.g. in the UI)

πŸ”„οΈ Additional Information

validating and inspecting http request body is pretty hard

πŸ‘€ Have you spent some time to check if this feature request has been raised before?

🏒 Have you read the Code of Conduct?

Are you willing to submit PR?

None

linear[bot] commented 2 months ago

NV-3893 πŸš€ Tech Feature: Specify the tenant id as HTTP header