novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.67k stars 3.46k forks source link

feat(js): Flatten localization prop type #5858

Closed desiprisg closed 3 days ago

desiprisg commented 4 days ago

What changed? Why was the change needed?

This PR flattens the localization prop, meaning that this:

localization={{
  inbox: {
    title: 'Inbox'
  }
}}

is now going to be specified as:

localization={{
  'inbox.title': 'Inbox'
}}

Screenshots

Autocomplete is implemented as well:

Screenshot 2024-06-27 at 5 56 11 PM
Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
linear[bot] commented 4 days ago

COM-77 Flatten localization prop

netlify[bot] commented 4 days ago

Deploy Preview for novu-design failed. Why did it fail? →

Name Link
Latest commit a2df3b39dcbea0376fd4b5cdb74b0300e53d3e3c
Latest deploy log https://app.netlify.com/sites/novu-design/deploys/667e7dd22574070008365182
netlify[bot] commented 4 days ago

Deploy Preview for dev-web-novu ready!

Name Link
Latest commit a2df3b39dcbea0376fd4b5cdb74b0300e53d3e3c
Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/667e7dd2c83ad00008bb6475
Deploy Preview https://deploy-preview-5858--dev-web-novu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LetItRock commented 3 days ago

question: ‏ I'm not really sure why this change is being done, is ther a place that gives more context for it?

@denis-kralj-novu This PR is part of the new Inbox component. There is a guide that might give you a little more context: https://www.notion.so/novuhq/Inbox-Localization-76ebff747b7845a988d0f531f16f8a8d?pvs=4