search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
34.59k stars 3.53k forks source link

refactor(framework): move types to shared #5864

Closed djabarovgeorge closed 3 months ago

djabarovgeorge commented 3 months ago

What changed? Why was the change needed?

We need to externalize these types and reuse them on the API, the framework, the Web and Worker.

Screenshots

Expand for optional sections ### Related enterprise PR [EE-PR](https://github.com/novuhq/packages-enterprise/pull/156) ### Special notes for your reviewer
linear[bot] commented 3 months ago

NV-3977 Externalize types for API, framework, and web app reuse

netlify[bot] commented 3 months ago

Deploy Preview for dev-web-novu ready!

Name Link
Latest commit d81b18191e12feb0c70db1de7b57898ba6a9f45d
Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/667e977cfd9f6000086c35e5
Deploy Preview https://deploy-preview-5864--dev-web-novu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for novu-design failed. Why did it fail? →

Name Link
Latest commit d81b18191e12feb0c70db1de7b57898ba6a9f45d
Latest deploy log https://app.netlify.com/sites/novu-design/deploys/667e977c2efdb500089652de
djabarovgeorge commented 3 months ago

Closing this one as we won't relocate the types from framework to shared package at the momnet.