search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.75k stars 3.46k forks source link

🐛 Bug Report: Layout shift in Editor Tab on toggle of `Add an Avatar` #5902

Open vaishak10 opened 2 weeks ago

vaishak10 commented 2 weeks ago

📜 Description

When you edit the In App step, The default view is the editor with Add and Avatar toggle and Add New Feed (optional) option in one side and Search Variables container on the other. The layout contains these 2 containers, But on clicking the Add an avatar toggle, The layout is disrupted and the Search Variables container moves below the Editor container. Even when you toggle back to original state, the Search Variables container is still beneath and doesn't move next to the editor container.

👟 Reproduction steps

When Creating Workflow, after setting up the trigger

  1. Add an In App step
  2. Edit The In App step
  3. Enter the required content inside the editor
  4. Click on Add an Avatar toggle beneath the Editor

👍 Expected behavior

The Variables container should be placed on the right side even when Add an avatar toggle is clicked. The editor and variables containers should not get misplaced in the editor view

Screenshot 2024-07-01 at 10 08 01 PM Screenshot 2024-07-01 at 10 27 59 PM

👎 Actual Behavior with Screenshots

The Variables container moves beneath editor container when clicked on the Add An Avatar Toggle

Screenshot 2024-07-01 at 10 10 16 PM

Novu version

Novu SaaS.

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

Once the layout shifts in the Editor tab, We will need to go to Preview tab and navigate again to Editor tab to see the containers in it's original form. Even if we,

  1. Select the Add an avatar toggle

    Screenshot 2024-07-01 at 10 25 39 PM

  2. Switch to Preview

    Screenshot 2024-07-01 at 10 25 47 PM

  3. Come back to Editor the containers are placed in it's original layout with Setup an avatar option available in the editor component

    Screenshot 2024-07-01 at 10 25 58 PM

Note: Switching the Add an avatar toggle again will cause the same shift in layout!

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

linear[bot] commented 2 weeks ago

NV-4065 🐛 Bug Report: Layout shift in Editor Tab on toggle of `Add an Avatar`

vaishak10 commented 2 weeks ago

To The Maintainer, I am willing to work on this issue as I have figured out the fix!