novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.75k stars 3.46k forks source link

✨ Polishing: Code Editor not to overflow the container #5903

Open vaishak10 opened 2 weeks ago

vaishak10 commented 2 weeks ago

πŸ“œ Description

Whenever I have used the Code editors in Email (Custom Code) and Twilio, the Code Editor section seems to be overflowing the container it is placed in. Not sure whether it is a bug or done intentionally, But for a good UX its better to place the code editor inside the container rather than giving the overflowing effect. Can take the reference of the code editor used in In App Step. The Code editor is well contained and doesn't overflow when you enter multiple lines of content.

  1. Novu Email

    Screenshot 2024-07-01 at 10 41 19β€―PM
  2. Screenshot 2024-07-01 at 10 39 12β€―PM

πŸ‘Ÿ Reproduction steps

  1. Edit Twilio or novu email step
  2. The look of Code editor. The editor overflows outside the container it is placed in

πŸ‘ Expected behavior

In App Step, The Code editor is well contained and doesn't overflow when you enter multiple lines of content.

  1. Novu In App
Screenshot 2024-07-01 at 10 39 33β€―PM

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

🏒 Have you read the Contributing Guidelines?

linear[bot] commented 2 weeks ago

NV-4066 ✨ Polishing: Code Editor not to overflow the container

vaishak10 commented 2 weeks ago

To the Maintainer, I am willing to work on this UI/UX update