novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
33.94k stars 3.47k forks source link

šŸ› Bug Report: Redirect URL's placeholder in workflow gets encoded when notification is sent #6040

Closed samya-ak closed 1 week ago

samya-ak commented 1 month ago

šŸ“œ Description

If the Redirect URL has placeholder for query parameters, query parameters placed in placeholder is encoded. eg: In this URL http://localhost:3000/projects/{{projectId}}/schedule?{{filters}}&something=something, query parameters placed in filters placeholder is encoded and. Albeit, &something=something remains as it is.

http://localhost:3000/projects/28800f71/schedule?scheduleType=DETAIL turns into http://localhost:3000/projects/28800f71/schedule?scheduleType=DETAIL

šŸ‘Ÿ Reproduction steps

  1. Create a workflow with Redirect URL that has placeholder for query parameters image

In above picture, filters placeholder may have multiple query parameters eg: scheduleType=DETAIL&projectType=PAID

  1. Send notification using above workflow with redirect URL

šŸ‘ Expected behavior

Placeholders in Redirect URL should not be encoded

šŸ‘Ž Actual Behavior with Screenshots

Placeholders in Redirect URL are encoded

Novu version

0.24.0

npm version

No response

node version

No response

šŸ“ƒ Provide any additional context for the Bug.

No response

šŸ‘€ Have you spent some time to check if this bug has been raised before?

šŸ¢ Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

linear[bot] commented 1 month ago

NV-4115 šŸ› Bug Report: Redirect URL in workflow gets encoded when notification is sent