Open fell-lucas opened 3 weeks ago
Thanks for reporting this. The require
d modules shown in your screenshot are not critical runtime dependencies of Framework and we should be able to make those dependencies conditional.
We plan to investigate conditional importing for these dependencies within the next 2 weeks.
📜 Description
We get build errors when deploying to CF pages because the package imports unsupported node dependencies.
Even though we are not using the JSON Schema features of @novu/framework, we still get these import errors. Is it possible to ask for conditional importing of the problematic dependencies?
👟 Reproduction steps
workflow
import from @novu/framework.api/novu/+server.ts
and import theserve
function from @novu/framework/sveltekit👍 Expected behavior
Not throw build errors because we're not relying on JSON Schema to create our workflows.
👎 Actual Behavior with Screenshots
Novu version
Novu SaaS
npm version
NA
node version
NA
📃 Provide any additional context for the Bug.
@novu/framework version: 2.0.0-canary.5
👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to submit PR?
Yes I am willing to submit a PR!