novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.44k stars 3.92k forks source link

feat(providers): provide the ability to send to include_external_user… #6979

Closed L-U-C-K-Y closed 1 week ago

L-U-C-K-Y commented 1 week ago

What changed? Why was the change needed?

Implements: https://github.com/novuhq/novu/issues/3479#issue-1721795062, https://discord.com/channels/895029566685462578/1185702635219714219/1185702635219714219

This pull request enhances the functionality of the OneSignal push notification provider by adding support for targeting users via external user IDs. It includes changes to the provider's main class and its test suite to accommodate this new feature.

Screenshots

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
netlify[bot] commented 1 week ago

Deploy request for novu-stg-vite-dashboard-poc pending review.

Visit the deploys page to approve it

Name Link
Latest commit 3af6f05a8fd3ff2f78809fe9a944d1dae21ceedf
suplere commented 1 week ago

Hello, this solution still use old API. The old API may be deprecated or even disabled over time. You use include_external_user_ids - but with old API.

L-U-C-K-Y commented 1 week ago

Hello, this solution still use old API. The old API may be deprecated or even disabled over time. You use include_external_user_ids - but with old API.

I agree, we should use this one, it's the more proper way: https://github.com/novuhq/novu/pull/6976