Closed L-U-C-K-Y closed 1 week ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 3af6f05a8fd3ff2f78809fe9a944d1dae21ceedf |
Hello, this solution still use old API. The old API may be deprecated or even disabled over time. You use include_external_user_ids - but with old API.
Hello, this solution still use old API. The old API may be deprecated or even disabled over time. You use include_external_user_ids - but with old API.
I agree, we should use this one, it's the more proper way: https://github.com/novuhq/novu/pull/6976
What changed? Why was the change needed?
Implements: https://github.com/novuhq/novu/issues/3479#issue-1721795062, https://discord.com/channels/895029566685462578/1185702635219714219/1185702635219714219
This pull request enhances the functionality of the OneSignal push notification provider by adding support for targeting users via external user IDs. It includes changes to the provider's main class and its test suite to accommodate this new feature.
Provider Class Changes:
oneSignalOptions
to the overrides in theOneSignalPushProvider
class to support targeting viainclude_external_user_ids
orinclude_player_ids
based on theuseExternalUserIds
flag.Interface Changes:
IPushOptions
interface to include the newoneSignalOptions
field with an optionaluseExternalUserIds
boolean property.Test Suite Additions:
include_external_user_ids
is used whenuseExternalUserIds
is true.include_player_ids
is used whenuseExternalUserIds
is false.include_player_ids
is the default whenoneSignalOptions
is not provided.…_ids instead of include_player_idsScreenshots
Expand for optional sections
### Related enterprise PR ### Special notes for your reviewer