search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.45k stars 3.92k forks source link

fix(dashboard): Modality on configure action popover #7000

Closed desiprisg closed 1 week ago

desiprisg commented 1 week ago

What changed? Why was the change needed?

Modality of popover is false by default, so configuring the action was not possible before, since clicking was considered as outside interaction and was closing the popover.

This would not be necessary if we were not inside a Sheet. Sheet is a modal and thus, when a popover is portaled into document.body it is "outside" our Sheet. By making it a modal, it can receive focus and is placed "on top" of the Sheet.

Another solution would be to not portal the popover or portal it in the Sheet. In that case though, it wouldn't be possible for it to escape the bounds of the Sheet in the screen.

Screenshots

https://github.com/user-attachments/assets/fa51e708-746f-43f2-b693-bed4e43e40a7

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
linear[bot] commented 1 week ago

NV-4755 🐛 [Function] - Unable to add redirect urls to Primary & Secondary action

netlify[bot] commented 1 week ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit f1e95c6823af04715dca8d21662965cfb9ae14f1
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6735de4a564ad60008cafaa1
Deploy Preview https://deploy-preview-7000--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.