search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.44k stars 3.92k forks source link

fix(api): duplicated control value storage #7008

Closed djabarovgeorge closed 2 days ago

djabarovgeorge commented 1 week ago

What changed? Why was the change needed?

Screenshots

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
djabarovgeorge commented 1 week ago

https://linear.app/novu/issue/NV-4760/saving-a-step-overwrites-other-steps-in-the-workflow

netlify[bot] commented 1 week ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit 4575eb73a7542af3319664e452656f5234a45cab
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67385b159f6c3800085b8100
Deploy Preview https://deploy-preview-7008--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SokratisVidros commented 1 week ago

I am closing this PR as I accidentally overwrote it. @djabarovgeorge let's check if this needs a new PR as after rebasing the code has changed.

pkg-pr-new[bot] commented 1 week ago

Open in Stackblitz

@novu/client

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@7008 ```

@novu/headless

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@7008 ```

@novu/framework

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@7008 ```

@novu/js

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@7008 ```

@novu/nextjs

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@7008 ```

@novu/node

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@7008 ```

@novu/notification-center

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@7008 ```

novu

``` pnpm add https://pkg.pr.new/novuhq/novu@7008 ```

@novu/providers

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@7008 ```

@novu/react

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@7008 ```

@novu/react-native

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@7008 ```

@novu/shared

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@7008 ```

commit: 4575eb7

djabarovgeorge commented 6 days ago

I am closing this PR as I accidentally overwrote it. @djabarovgeorge let's check if this needs a new PR as after rebasing the code has changed.

Got it, @SokratisVidros. I merged next to this branch, and the changes still exist (fix-duplicated-control-values-storage to next), so I wonder if we still need to merge this one. I will open it for now.