search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.43k stars 3.92k forks source link

fix(dashboard): Fix step deletion not working #7010

Closed desiprisg closed 6 days ago

desiprisg commented 1 week ago

What changed? Why was the change needed?

Weirdly enough, the issue seems to be that steps.remove() doesn't actually remove the step, it just deletes some properties from it. Don't know why. Are we sure this was working before? I updated it to use steps.replace() and it works but I'm not convinced.

I've also updated the dep and made a couple of cleanups.

Screenshots

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
linear[bot] commented 1 week ago

NV-4759 Step is not being deleted

netlify[bot] commented 1 week ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit 3920295af95ffa5b7de40e7838f47d0d590b19cf
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6736771714257200089142a6
Deploy Preview https://deploy-preview-7010--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.