novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.43k stars 3.92k forks source link

fix(api): add patch step api and consolidate post update processing #7015

Closed tatarco closed 6 days ago

tatarco commented 1 week ago

What changed? Why was the change needed?

  1. Added a Patch Step supporting name + control values.
  2. Add e2e tests to validate the behavior stays consistent.
  3. Deprecate (but not delete) existing way of updating to not break FE.
  4. migrate internals into a joint logic for upsert and patch in order to remove it easily next week.
  5. consolidate postprocess logic (issues + payload schema builder) to work after patch & upsert to keep a consistent behavior

Screenshots

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
linear[bot] commented 1 week ago

NV-4758 Create a PATCH step

netlify[bot] commented 1 week ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit 9b34609fbcc297706d6e84bd59c9207b4f989163
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67373b83cf55470008418fee
Deploy Preview https://deploy-preview-7015--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new[bot] commented 1 week ago

Open in Stackblitz

@novu/client

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@7015 ```

@novu/framework

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@7015 ```

@novu/headless

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@7015 ```

@novu/js

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@7015 ```

@novu/nextjs

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@7015 ```

@novu/node

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@7015 ```

@novu/notification-center

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@7015 ```

novu

``` pnpm add https://pkg.pr.new/novuhq/novu@7015 ```

@novu/providers

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@7015 ```

@novu/react

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@7015 ```

@novu/react-native

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@7015 ```

@novu/shared

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@7015 ```

commit: 9b34609