novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.44k stars 3.92k forks source link

fix(dashboard): propagate saved step changes to in-app step editor #7053

Closed ChmaraX closed 2 days ago

ChmaraX commented 3 days ago

What changed? Why was the change needed?

The changes in this PR fixes the In-App Editor form dirty state which is also used to show the "unsaved changes" modal.

The strategy that we currently have:

Screenshots

https://github.com/user-attachments/assets/57cf56d6-4a6f-46ac-9fa3-3a5888b87c6d

https://github.com/user-attachments/assets/6e1eee20-dd0c-4630-82e4-0088af1f47c7

linear[bot] commented 3 days ago

NV-4769 🐛 [Functional] - "You might lose changes" modal always appears after saving step

netlify[bot] commented 3 days ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit b1e78368c8aad3962ae1ade315c8946be5610325
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/673c91b90e0f7e000869f9b4
Deploy Preview https://deploy-preview-7053--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new[bot] commented 2 days ago

Open in Stackblitz

@novu/client

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@7053 ```

@novu/framework

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@7053 ```

@novu/headless

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@7053 ```

@novu/js

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@7053 ```

@novu/nest

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@7053 ```

@novu/nextjs

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@7053 ```

@novu/node

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@7053 ```

@novu/notification-center

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@7053 ```

novu

``` pnpm add https://pkg.pr.new/novuhq/novu@7053 ```

@novu/providers

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@7053 ```

@novu/react

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@7053 ```

@novu/react-native

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@7053 ```

@novu/shared

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@7053 ```

@novu/stateless

``` pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@7053 ```

commit: b1e7836