novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.43k stars 3.92k forks source link

fix(dashboard): workflow editor name change updates the workflow slug in the url #7064

Closed LetItRock closed 2 days ago

LetItRock commented 2 days ago

What changed? Why was the change needed?

This PR fixes the case when the workflow name is updated in the Workflow Editor we generate a new slug for the workflow on the BE, which should also update the slug used in the URL to make it a source of truth.

All the useFetchWorkflow, useFetchStep, useUpdateWorkflow hook should use the workflow id from the slug as the key for the react-query state.

Screenshots

https://github.com/user-attachments/assets/c696d5d6-9c05-4547-8c82-d6b727869ca5

https://github.com/user-attachments/assets/ff80cb4a-fbd0-48b1-8f9d-37d0cf3492ca

netlify[bot] commented 2 days ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit 7aab6704f3d0eb53833347836c4d90e655b1e807
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/673cae8fd1ceda0009d28ee4
Deploy Preview https://deploy-preview-7064--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.