search

novuhq / novu

Open-Source Notification Platform. Embeddable Notification Center, E-mail, Push and Slack Integrations.
https://novu.co
Other
35.43k stars 3.92k forks source link

fix(dashboard): Make preferences.default a nullable field #7068

Closed desiprisg closed 2 days ago

desiprisg commented 2 days ago

What changed? Why was the change needed?

Screenshots

Expand for optional sections ### Related enterprise PR ### Special notes for your reviewer
linear[bot] commented 2 days ago

NV-4814 🐛 Autosave doesn't save workflow name

netlify[bot] commented 2 days ago

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
Latest commit ed0b2578ff7cf193a067e7a7867d9e0040b06585
Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/673cb5541971750008c83ca6
Deploy Preview https://deploy-preview-7068--novu-stg-vite-dashboard-poc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rifont commented 2 days ago

With the current API validation and implementation, there are no cases where default preferences will be persisted as null. The frontend always calls the PUT /v2/workflows/{id} endpoint with the object retrieved from GET /v2/workflows{id}, so we can safely close this PR.

Any cases where the default: null issue arose are from a previous broken implementation during development of Dashboard V2, and should be considered "corrupt".