novus / nvd3

A reusable charting library written in d3.js
http://nvd3.org/
Other
7.22k stars 2.14k forks source link

will it be compatible with d3.v3 ? #36

Closed firebat closed 11 years ago

rmleon commented 11 years ago

Maybe. Certainly we've been keeping an eye on d3.v3 and we'd like to make it compatible.

twolfnovus commented 11 years ago

Some day. That's definitely a todo

danse commented 11 years ago

i had some problems and lost a lot of time because of this incompatibility, since there is not component.json file nor a clear statement that just d3 version 2 is supported, i would like at least to have this issue open in order to spot it more easily

pdwinkel commented 11 years ago

+1 for d3 version 3

matthelm commented 11 years ago

+1 from me too

devilankur18 commented 11 years ago

+1

twolfnovus commented 11 years ago

The day has come.

Check out the d3v3_Upgrade branch. It currently reflects master, but all charts have been updated to work with d3v3. I'm not merging to master yet because I'd like to test more thoroughly to make sure I didn't miss anything. Post any issues you run into so we can make master v3 compatible!

twolfnovus commented 11 years ago

We're stepping up for NVD3 v0.9 update very soon. The big change in the code is d3.v3 support. Expect the update soon!

j0hnsmith commented 11 years ago

excellent, looking forward to it

dzimine commented 11 years ago

For your tracking: nv.utils.windowResize(chart.update) works in d3.v2, but throws exception in d3.v3 - I stepped to it for lineChart.

robinfhu commented 11 years ago

NVD3 upgraded to d3 version 3. Closing.