now-u / now-u-campaigns

now-u website

https://now-u.com

2 stars 6 forks source link

Added scroll to top feature #122

Closed wolflikesam closed 3 years ago

wolflikesam commented 3 years ago

Description

When you click on a link the scroll position is reset and takes you to the top of the page.

Fixes https://trello.com/c/umJdpeCc/385-scroll-to-top-on-page-change

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have reviewed the 'files changed' tab on github to ensure all changes are expected
[x] I have added someone to review the pr

stellenberger commented 3 years ago

Nice work, clean solution 👍 One small thing; could you clone the now-u-campaigns repo locally, and work off directly as you are a contributor (as opposed to forking it and merging it in). Just makes the reviewers life easier as they can pull the branch locally and check it out! Approved.