Open BecaLParker opened 2 years ago
Name | Link |
---|---|
Latest commit | 5132e69465f9acc4d92ca45f7cf5249425d8e0fb |
Latest deploy log | https://app.netlify.com/sites/staging-now-u/deploys/629f784ccde07200088bce5b |
Deploy Preview | https://deploy-preview-133--staging-now-u.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@JElgar / @stellenberger could I get a review on this PR please?
GitHub won't let me add you as reviewers for some reason.
Ive added a note on this issue https://tree.taiga.io/project/jelgar-now-u-1/task/95 for the bottom nav links being broken
I've put this back to draft PR status so I can use this branch to work on the footer nav too
Hi @JElgar / @stellenberger. This PR now has the work done on the footer too and is ready for review.
Ideally this could do with some refactoring (eg extract some shared components for the footer to avoid hard-coded duplication in MobileFooter.jsx and WebFooter.jsx), but I've run out of time this week.
Ive added a note on this issue https://tree.taiga.io/project/jelgar-now-u-1/task/95 for the bottom nav links being broken
The navlinks in the footer work OK for me, although I haven't changed anything about how the href is generated - so please re-check when you review this PR.
I've just spotted one minor thing for a mid-sized screen:
so we can card it up for another ticket if its too difficult to fix on this PR!
This doesn't feel like part of this PR, so please could we card it up and do it as part of the homepage changes later?
Description
See taiga epic
create new navigation
New top nav bar New footerChecklist: