Closed stellenberger closed 4 years ago
Oh I just read this "One issue is at the bottom of the header image there is a thin black border from the resulting black background of the div.". Shows I haven't done a very good job of reviewing the pr :laughing:.
If you add max-height: 300px;
to the black thing that seems to do the trick (same as the image so maybe set a header_height variable for this)
Edit: in-fact a better solution is to remove the height: 100% from both the header image and black thing and just set them to the header_height variable and then you can remove the max-height completely
One other thing is, is there any way we can keep the videos aspect ration 16:9? Opposed to having this stretching on mobile (or large displays)
So here is the campaign v12 design implemented. I have also done the footer, so that should also be applicable on other pages, too.
One issue is at the bottom of the header image there is a thin black border from the resulting black background of the div.